Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM-154] Add labelledby to dialogs #3439

Merged
merged 12 commits into from
Sep 8, 2022
Merged

[SM-154] Add labelledby to dialogs #3439

merged 12 commits into from
Sep 8, 2022

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 2, 2022 •
edited
Loading

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adds aria-labelledby to dialogs using a new directive dialog-title-container. The title container has an ID which it exposes to the dialog container.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Hinton Hinton changed the title Add role dialog and labelledby to dialogs [SM-154] Add role dialog and labelledby to dialogs Sep 2, 2022
danielleflinn
danielleflinn previously approved these changes Sep 2, 2022
View reviewed changes
@Hinton
Copy link
Member Author

Hinton commented Sep 2, 2022

Seems I need to change how this is implemented slightly. The dialog role is applied by the dialog service, which also supports a aria-labelledby which we should use there.

@Hinton Hinton removed the request for review from Thomas-Avery September 2, 2022 15:46
@Hinton Hinton marked this pull request as draft September 2, 2022 15:46
@Hinton Hinton marked this pull request as ready for review September 5, 2022 10:20
@Hinton Hinton changed the title [SM-154] Add role dialog and labelledby to dialogs [SM-154] Add labelledby to dialogs Sep 5, 2022
@Hinton Hinton mentioned this pull request Sep 5, 2022
Merged
patrickhlauke added a commit to patrickhlauke/bitwarden that referenced this pull request Sep 5, 2022
@patrickhlauke
Pull in changes to libs dialog headings from bitwarden#3439
05bb1c7 
to avoid conflicts/overwriting bitwarden#3439
Thomas-Avery
Thomas-Avery approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no concerns.

@Hinton Hinton merged commit cb31a71 into master Sep 8, 2022
@Hinton Hinton deleted the hotfix/dialog-labelledby branch September 8, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleflinn danielleflinn danielleflinn approved these changes

@Thomas-Avery Thomas-Avery Thomas-Avery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @Thomas-Avery @danielleflinn