Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EC-641] Browser Ext UI Update #3842
[EC-641] Browser Ext UI Update #3842
Changes from 2 commits
cd8cc63
d57e909
fd1f0b6
1d42dbe
1259cd0
4d4b10f
ad4eb68
623240e
f645129
e271198
b5c7a10
4004219
be1b412
3a3b667
31bf01f
51615c5
8bd18f5
fbc3adc
0aa4103
de15d9b
246768c
b800710
ae661aa
8f2ae2b
a0ef655
46eafaa
03c95b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we removed the borders from the boxes, Solarize Dark theme seems to need adjustments as there is nothing visually separating the rows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed the issue for the most part. I think there's a little more cleanup to do possibly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only bit of feedback is we should probably add a new lighter variable for the hover color so that the hover state is retained.
Edit: actually hover state in settings looks good; however it isn't showing up on the main Tab or Vault pages or 'password history' in Generator