merge master #3851
Merged
merge master #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions <>
Co-authored-by: github-actions <>
Co-authored-by: github-actions <>
* [refactor] Isolate form validation logic * [refactor] Relocate a few input scrubbing lines * [refactor] Isolate RegisterRequest object construction logic * [refactor] Isolate account registration logic * [refactor] Isolate login logic * [fix] Check for captchas during login from trial initiation * [fix] Avoid a duplicated toast if the account was already created
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* [CL-44] Update button disabled state * [CL-44] [EC-525] Fixed opacity issue with background/border
…users (#3509) * [SG-659] Fixed TOTP code visibility for users with classic plans. * [SG-659] Refactored condition. * [SG-659] Ran prettier * [SG-659] Simplified expression.
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Bump rust dependencies * Selecitvely upgrade only napi * Upgrade only parking_lot_core
Co-authored-by: github-actions <>
Co-authored-by: github-actions <>
Co-authored-by: github-actions <>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* [EC-457] feat: initial version of icon button * [EC-457] feat: modify template and start adding inputs * [EC-457] feat: implement all styles * [EC-457] chore: cleanup * [EC-457] feat: fix hover styles after discussions * [EC-457] feat: add focus ring workaround * [EC-457] chore: refactor stories a bit * [EC-457] fix: button style attr name reserved word collision * [EC-356] feat: match padding with figma * [EC-457] feat: use icon button in banner * [EC-457] chore: cleanup css classes * [EC-457] feat: improve aria * [EC-457] feat: use icon button in dialog * [EC-457] fix: make focus and hover styles independent * [EC-457] fix: remove primary 500 border * [EC-457] chore: cleanup * [EC-457] chore: move css class to common list * [EC-457] fix: use focus-visible * [EC-457] chore: expand on workaround fix * [EC-457] fix: default sizing * [EC-457] fix: align trash icon right * [EC-457] fix: add missing aria labels * [EC-457] fix: add i18n service to banner tests * [EC-457] chore: rename size `default` to `button` * [EC-457] feat: double padding * [EC-457] feat: simplify sizes - update default * [EC-457] fix: revert selector fix - gonna create separate pr * [EC-457] chore: remove superfluous dependencies * [EC-457] fix: remove non-working onClose handler Removing this storybook action because we already test it as part of the dialog service stories. It requries mocking the dialogRef to capture the close function which makes this story more complex but adds very little value as we already test it elsewhere.
…tems (#3188) * PS-1111 Added prefix "Vault:" for accessibility to vault selector items * improved html readability * PS-1111 Added more screen reader accessibility data to the Vault selector on Desktop and Web clients * PS-1111 removed duplicated aria-label * PS-1111 Removed unnecessary aria-label attribute * PS-1111 Changed browser vault item accessibility title from span to button
* Fix repository url to point to the clients repo * Fix missing description in snapcraft.yml * Nuspec: Fix links to point to clients repo * Nuspec: Use the correct brand icon(same as desktop) * Nuspec:Update description based on other stores (browser)
* Create banner.stories.mdx Added documentation for Banner component in Common * Update banner.stories.mdx Added comment to test verification * Update banner.stories.mdx Removing test comment * Trying our referencing stories in banner mdx * fix: build errors * Added stories for banner info, warning, danger * Formatting update libs/components/src/banner/banner.stories.ts Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Update banner.stories.mdx Added list formatting to text for readability, added section for Accessibility * Update libs/components/src/stories/banner.stories.mdx Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * Update libs/components/src/stories/banner.stories.mdx Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com> * Updated banner.stories.mdx Added section for Accessibility, improvements to text formatting for readability Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
* updated naming of common to documentation * Add button docs * updated sort order Documentation is now above the component library and allows the general pages to come before the component specific ones. * fixed typos * updated file name * fixed typo in introduction.stories.mdx * updated banner.stories.mdx to match new docs structure * remove plural in button docs
* [EC-450] Added show SCIM key toggle button * [EC-450] Add id on the showApiKey button
* Add generate command * Add JSDoc * Minor improvements * Remove unneeded comment * Make some properties optional * Remove main.background.ts changes * One more * Lint * Make all but length optional * Address PR feedback * Move generate command code to command * Address PR feedback * Use new alarm scheme * Let feature handle state keys Moves to a feature folder and creates clipboard-module level state handler functions. StateService is being paired down to storage routing, so we are handling storage specifics in-module. Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Daniel Smith <djsmith85@users.noreply.github.com> * Missed some changes Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Daniel Smith <djsmith85@users.noreply.github.com>
PR #3575 merged in master just before the file name changes were enforced in CI
* Move AccountService.delete to Internal * Remove unnecessary promise
only uploading Chrome, Edge and Opera artifacts for now, as those support manifest V3 Also corrects build artifact to lower case.
* Add needed factories for AuthService WIP: Allow console logs * Add badge updates * Init by listener * Improve tab identification * Define MV3 background init * Init services in factories. Requires conversion of all factories to promises. We need to initialize in factory since the requester of a service doesn't necessarily know all dependencies for that service. The only alternative is to create an out parameter for a generated init function, which isn't ideal. * Improve badge setting * Use `update-badge` in mv2 and mv3 Separates menu and badge updates * Use update-badge everywhere * Use BrowserApi where possible * Update factories * Merge duplicated methods * Continue using private mode messager for now * Add static platform determination. * Break down methods and extract BrowserApi Concerns * Prefer strict equals * Init two-factor service in factory * Use globalThis types * Prefer `globalThis` * Use Window type definition updated with Opera Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> * Distinguish Opera from Safari Opera includes Gecko, Chrome, Safari, and Opera in its user agent. We need to make sure that we're not in Opera prior to testing Safari. * Update import * Initialize search-service for update badge context * Build all browser MV3 artifacts only uploading Chrome, Edge and Opera artifacts for now, as those support manifest V3 Also corrects build artifact to lower case. * Remove individual dist Co-authored-by: Justin Baur <justindbaur@users.noreply.github.com> Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
… page (#3820) * added 2fa enabled * added passwordless authentication to 2fa * passwordless strategy to authservice * changes to 2FA to allow email sending for passwordless * updated imports
* updated title case to sentence case also added grammatical improvement to confirmation messages * capitalized 'vault' also updated the term personal vault to individual vault * capitalized 'send' * capitalized 'provider' also caught some straggling lowercase 'vaults' * sentence case 'organizations,' 'owners', and 'admins' * updated more casing to sentence * lowercase vault * Updated Premium to title case * fixed typos * Fixed typos and removed 'disable' * updated two-step login terms * Fixed missed sentence casing * Fixed missed sentence case * lowercased groups fixed other missed sentence case items as well * fixe membership casing * uppercase plan casing addressed other comments from Fred. * casing on billing sync and trash * uppercase Social Security * fixed single sign-on casing fixed Enterprise policy casing * merging in master * replaced enabled * fixed typos Co-authored-by: Patrick <94560851+patrick-bitwarden@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* Initial - add folder id to popup item view * Add folder service to view component * Move folder info higher in the item view as proper box * Add folder name handling to component * Add folder field to browser view * Add folder field to desktop view * Make folder field draggable following the merging of #3321 also make the folder field draggable * Use `<label>` and readonly `<input>` In anticipation of #3485 being merged * Changes from review - change input name to `folderName`, match it in the `for` attribute on the `<label>` - add an `if` check before querying folder names * Match `name` to `id` Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Update Web styles and CSP to support MultiSelect component - Include the MultiSelect module in the CL barrel file of exports - Import the MultiSelect scss into the Web styles.scss - Add the necessary sha256 hash to webpack CSP policy to support ngSelect inline styles * Undo removal of 127.0.0.1 from webpack CSP
vgrassia
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged in master branch