Migrate SecretsManager to new crypto interface #4879
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Since the Folder and Cipher refactors is stalled, I've refactored the secrets manager portion and will look into rebasing the folder work after.
Commits are structured in order and I believe the easiest way to review this is to go commit by commit.
Significant change from #3732 is that
KeyRetrieval
is extracted from the interfaces and only required byCryptoService
.Code changes
Before you submit