Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SecretsManager to new crypto interface #4879

Closed
wants to merge 7 commits into from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 27, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Since the Folder and Cipher refactors is stalled, I've refactored the secrets manager portion and will look into rebasing the folder work after.

Commits are structured in order and I believe the easiest way to review this is to go commit by commit.

Significant change from #3732 is that KeyRetrieval is extracted from the interfaces and only required by CryptoService.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Hinton Hinton requested review from MGibson1 and eliykat February 27, 2023 10:54
@eliykat eliykat removed their request for review June 13, 2023 23:25
@eliykat
Copy link
Member

eliykat commented Jun 13, 2023

Removing myself from reviewers on the understanding this will be done in the SDK instead.

@Hinton Hinton closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants