Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1689] Add restriction to only encrypt fails on browser #5575

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

gbubemismith
Copy link
Member

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The PR for adding validations to ensure new encryption isn't called when the server doesn't support it works on all clients except the browser.

Code changes

The initial failure was due to the CipherService attempting to access the configApiService before it had been instantiated. To resolve this issue, I ensured the ConfigApiService was initialized within the main.background.ts file on the browser client side.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@gbubemismith gbubemismith requested a review from a team June 8, 2023 13:41
@gbubemismith gbubemismith added the needs-qa Marks a PR as requiring QA approval label Jun 8, 2023
Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @gbubemismith ! I had to double-check that we needed the ConfigApiService in the background, but it appears that we do as CipherService needs it.

@gbubemismith gbubemismith removed the needs-qa Marks a PR as requiring QA approval label Jun 8, 2023
@gbubemismith gbubemismith merged commit a8461c8 into feature/individual-vault-items Jun 8, 2023
@gbubemismith gbubemismith deleted the PM-1689 branch June 8, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants