Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-3169] Login decryption options in extension popup #5909

Merged
merged 24 commits into from
Aug 4, 2023
Merged

[PM-3169] Login decryption options in extension popup #5909

merged 24 commits into from
Aug 4, 2023

Commits on Jul 27, 2023

  1. [PM-3169] refactor: lock guard and add new redirect guard

    @coroiu
    coroiu committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5493a58 View commit details
    Browse the repository at this point in the history

  2. [PM-3169] feat: implement fully rewritten routing

    @coroiu
    coroiu committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f7a8dc5 View commit details
    Browse the repository at this point in the history

  3. [PM-3169] feat: close SSO window

    @coroiu
    coroiu committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    cf13946 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. [PM-3169] feat: store sso org identifier in state

    @coroiu
    coroiu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    63a9887 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/trusted-device-encryption' into PM-3169-login-d… 

    …ecryption-options-in-extension-popup
    @coroiu
    coroiu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0254c38 View commit details
    Browse the repository at this point in the history

  3. [PM-3169] fix: tests

    @coroiu
    coroiu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    10f5ead View commit details
    Browse the repository at this point in the history

  4. [PM-3169] feat: get rid of unconventional patch method

    @coroiu
    coroiu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e502ce2 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Merge branch 'feature/trusted-device-encryption' into PM-3169-login-d… 

    …ecryption-options-in-extension-popup
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    eab5a4d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Merge branch 'feature/trusted-device-encryption' into PM-3169-login-d… 

    …ecryption-options-in-extension-popup
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e8684fc View commit details
    Browse the repository at this point in the history

  2. PM-3169 - SSO & 2FA Comps - Update naming of new callback to match ex… 

    …isting pattern + add tests for callback logic execution.
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b6f791c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/trusted-device-encryption' into PM-3169-login-d… 

    …ecryption-options-in-extension-popup
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f86f44d View commit details
    Browse the repository at this point in the history

  4. PM-3169 - Update LockGuard to have a special exception for allowing t… 

    …he TDE Login with MP flow
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    268c8fa View commit details
    Browse the repository at this point in the history

  5. PM-3169 - Per discussion w/ Jake and Justin, rename login-initiated g… 

    …uard to be tde decryption required guard (more named for functionality vs specific route)
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    32f0201 View commit details
    Browse the repository at this point in the history

  6. PM-3169 - Add some additional context to new redirect guard scenario

    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    62a0b5e View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. PM-3169 - Per PR feedback, replace all callback types with Promise<vo… 

    …id> as the return values are not being used.
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    22e1980 View commit details
    Browse the repository at this point in the history

  2. PM-3169 - StateSvc - Per PR feedback, update setUserSsoOrganizationId… 

    …entifier signature to explicitly use null instead of partial<string> which doesn't do anything
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0c1461e View commit details
    Browse the repository at this point in the history

  3. PM-3169 - Replace onSuccessfulLogin type to compile

    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8758ddb View commit details
    Browse the repository at this point in the history

  4. PM-3169 - Add clarification comment for why we are not using a query … 

    …param for persisting the org identifier
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f42f04c View commit details
    Browse the repository at this point in the history

  5. PM-3169 - Per discussion with Justin, only use memory for SsoOrgId as… 

    … we don't need to persist it beyond that; tested and it worked on all 3 clients for new user TDE creation
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    237b3f3 View commit details
    Browse the repository at this point in the history

  6. PM-3169 - Add missing ssoIdentifierRequired translation to desktop an… 

    …d browser
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7934371 View commit details
    Browse the repository at this point in the history

  7. PM-3169 - After discussing with Justin again, we realized that memory… 

    … doesn't work on desktop if user refreshes app or closes and re-opens it so must use disk.
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    deb75ea View commit details
    Browse the repository at this point in the history

  8. PM-3169 - Per PR feedback, remove hasEverHadUserKey logic as we can j… 

    …ust leverage existing getUserKey method to check if we have a user key or not; tested all guards in browser and web with no issues
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e754ba6 View commit details
    Browse the repository at this point in the history

  9. PM-3169 - Per design discussion with Danielle, move account created t… 

    …oast after successful account creation vs on load of page.
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    82f7b98 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/feature/trusted-device-encryptio… 

    …n' into PM-3169-login-decryption-options-in-extension-popup + browser sso comp tiny merge conflict
    @JaredSnider-Bitwarden
    JaredSnider-Bitwarden committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7cf92a2 View commit details
    Browse the repository at this point in the history