Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-1722] gracefully fail if site prompts user for passkey on load #6089

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[PM-1722] gracefully fail if site prompts user for passkey on load #6089

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d3c594
added error logic to look for options.mediation in page-script
Jingo88 Aug 22, 2023
f82cfc1
moved the options mediation logic into the try catch. changed error t…
Jingo88 Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/browser/src/vault/fido2/content/page-script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { FallbackRequestedError } from "@bitwarden/common/vault/abstractions/fido2/fido2-client.service.abstraction";

import { WebauthnUtils } from "../../../browser/webauthn-utils";

import { MessageType } from "./messaging/message";
Expand Down Expand Up @@ -95,7 +97,12 @@
abortController?: AbortController
): Promise<Credential> => {
const fallbackSupported = browserNativeWebauthnSupport;

try {
if (options?.mediation && options.mediation !== "optional") {
throw new FallbackRequestedError();
}

Check notice on line 105 in apps/browser/src/vault/fido2/content/page-script.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)

ℹ New issue: Complex Method 

navigator.credentials.get has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
const response = await messenger.request(
{
type: MessageType.CredentialGetRequest,
Expand Down
Loading