[PM-3810] Unify Passkeys view #6335
CodeScene PR Check
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 12 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Details
✅ Positive Code Health Impact (highest to lowest):
- Complex Conditional filter-function.ts: createFilterFunction
- Overall Code Complexity vault-items.component.ts
- Overall Code Complexity vault.component.ts
- Complex Method vault-items.component.ts: VaultItemsComponent.ngOnInit
- Complex Method vault-filter.model.ts: VaultFilter.buildFilter
- Complex Method vault.component.ts: VaultComponent.viewCipherMenu
- Complex Method vault-items.component.ts: VaultItemsComponent.buildFilter
- Complex Method filter-function.ts: createFilterFunction
- Complex Method icon.component.ts: IconComponent.ngOnInit
- Complex Method vault-filter.model.ts: VaultFilter.buildFilter
- Bumpy Road Ahead vault-filter.model.ts: VaultFilter.buildFilter
- Complex Method share.component.ts: ShareComponent.checkFido2KeyExistsInOrg
Annotations
Check notice on line 101 in apps/browser/src/vault/popup/components/vault/vault-items.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
VaultItemsComponent.ngOnInit decreases in cyclomatic complexity from 28 to 27, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 267 in apps/browser/src/vault/popup/components/vault/vault-items.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
VaultItemsComponent.buildFilter decreases in cyclomatic complexity from 18 to 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in apps/browser/src/vault/popup/components/vault/vault-items.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.83 to 5.33, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 107 in libs/angular/src/vault/components/icon.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
IconComponent.ngOnInit decreases in cyclomatic complexity from 22 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 48 in libs/angular/src/vault/vault-filter/models/vault-filter.model.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
VaultFilter.buildFilter decreases in cyclomatic complexity from 28 to 26, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 130 in libs/angular/src/components/share.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ No longer an issue: Complex Method
ShareComponent.checkFido2KeyExistsInOrg is no longer above the threshold for cyclomatic complexity
Check notice on line 359 in apps/desktop/src/vault/app/vault/vault.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
VaultComponent.viewCipherMenu decreases in cyclomatic complexity from 23 to 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in apps/desktop/src/vault/app/vault/vault.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.79 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
createFilterFunction decreases in cyclomatic complexity from 37 to 36, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Conditional
createFilterFunction decreases from 5 complex conditionals with 14 branches to 4 complex conditionals with 12 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Complex Method
VaultFilter.buildFilter decreases in cyclomatic complexity from 30 to 28, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
✅ Getting better: Bumpy Road Ahead
VaultFilter.buildFilter decreases from 4 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (EC-598-beeep-properly-store-passkeys-in-bitwarden)
ℹ Getting worse: Excess Number of Function Arguments
EmergencyAddEditComponent.constructor increases from 17 to 18 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.