[PM-5880] Refactor browser platform utils service to remove window references
#7885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic between the BrowserPlatformUtils and offscreen document
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7885 +/- ##
==========================================
+ Coverage 25.15% 25.31% +0.15%
==========================================
Files 2252 2254 +2
Lines 65846 65894 +48
Branches 12414 12415 +1
==========================================
+ Hits 16566 16679 +113
+ Misses 47938 47870 -68
- Partials 1342 1345 +3 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…within the BrowserPlatformUtilsService
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
dani-garcia
previously approved these changes
Feb 28, 2024
…tils-service-to-remove-window-reference
jprusik
reviewed
Feb 28, 2024
| * | ||
| * @param expectedVersion - The expected manifest version to check against. | ||
| */ | ||
| static isManifestVersion(expectedVersion: 2 | 3) { |
There was a problem hiding this comment.
non-blocking naming nit (the nittiest) - don't bother if you don't need to make other changes, tho
Suggested change
| static isManifestVersion(expectedVersion: 2 | 3) { | |
| static isManifestVersion(expectedManifestVersion: 2 | 3) { |
jprusik
reviewed
Feb 28, 2024
| * | ||
| * @param expectedVersion - The expected manifest version to check against. | ||
| */ | ||
| static isManifestVersion(expectedVersion: 2 | 3) { |
There was a problem hiding this comment.
non-blocking nit/question:
I'm guessing no, but Is there a scenario where either of these two values in the comparison are not 2 or 3 (say, undefined)? Should we defend against that scenario?
Another way I'm thinking about it; any reason to replace BrowserApi.manifestVersion === 3 with this method other than (the slightly improved) conciseness?
jprusik
previously approved these changes
Feb 28, 2024
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
…tils-service-to-remove-window-reference
dani-garcia
previously approved these changes
Mar 5, 2024
…tils-service-to-remove-window-reference
dani-garcia
approved these changes
Mar 6, 2024
…tils-service-to-remove-window-reference
jprusik
approved these changes
Mar 6, 2024
cagonzalezcs
deleted the
autofill/pm-5880-refactor-browser-platform-utils-service-to-remove-window-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The goal for this ticket is to remove a direct dependency on the
windowobject within theBrowserPlatformUtilsService. To do this, we are refactoring the typing information within the service, adjusting how the service is instantiated to remove dependence on thewindowobject, and reworking the clipboard related methods to conditionally use thechrome.offscreenAPI when we the extension is built using manifest v3.Code changes
windowobject when handling a copy to clipboard actionwindowobject when handling a copy to clipboard actionwindowobject when handling a copy to clipboard actionwindowobject that directly affect theBrowserPlatformUtilsServiceclass.windowobject when handling a copy to clipboard actionoffscreenAPI to the manifestBrowserApiclass.isManifestVersionmethod that simplifies checking for mv3, as well as methods for creating and closing offscreen documents as needed.ServiceWorkerGlobalScope. This likely should be updated at some point, but scoping down the expected service worker scope to specific files, especially when they might switch between mv2 and mv3, has proven difficult.BrowserClipboardServiceclassBrowserPlatformUtilsServiceclass. The two public methodscopyandreadfirst attempt to enact their behavior using the Clipboard API, and on failure will fallback to legacy methods. This allows us to have the same behavior within theBrowserPlatformUtilsServiceclass as well as the offscreen document.BrowserPlatformUtilsServiceclasswindowobjects throughout the script, and reworked the copy/read from clipboard functionality.