[PM-4882] Passkeys: funnel rp name or id to the cipher name on save #7969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7969 +/- ##
===========================================
- Coverage 59.32% 24.91% -34.41%
===========================================
Files 1057 2239 +1182
Lines 27253 65598 +38345
Branches 5453 12378 +6925
===========================================
+ Hits 16167 16347 +180
- Misses 9756 47918 +38162
- Partials 1330 1333 +3 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
merissaacosta
changed the title
coroiu
previously approved these changes
Feb 21, 2024
gbubemismith
previously approved these changes
Feb 26, 2024
merissaacosta
dismissed stale reviews from gbubemismith and coroiu
via
ff9a2a7
merissaacosta
commented
Feb 28, 2024
| @@ -296,7 +296,7 @@ export class Fido2Component implements OnInit, OnDestroy { | |||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |||
| this.router.navigate(["/add-cipher"], { | |||
| queryParams: { | |||
| name: Utils.getHostname(this.url), | |||
| name: data.credentialName || data.rpId, | |||
There was a problem hiding this comment.
update: had to funnel in the credentialName and rpId here as well for when creating a new cipher (see last screenshot)
There was a problem hiding this comment.
I was gonna suggest using ?? instead, but realized that || is actually better because it also covers an empty string "" 👍
coroiu
approved these changes
Feb 29, 2024
| @@ -296,7 +296,7 @@ export class Fido2Component implements OnInit, OnDestroy { | |||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |||
| this.router.navigate(["/add-cipher"], { | |||
| queryParams: { | |||
| name: Utils.getHostname(this.url), | |||
| name: data.credentialName || data.rpId, | |||
There was a problem hiding this comment.
I was gonna suggest using ?? instead, but realized that || is actually better because it also covers an empty string "" 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
When creating a passkey and a new vault item, we want to set
nameto berp's name value (rp.name). If therpdoes not provide a name then we save rp.id which is the urlCode changes
Screenshots
(see the "target" name in the extension)
Before you submit