-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6404] Initial Clear Events Code #8029
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8029 +/- ##
==========================================
+ Coverage 24.71% 24.76% +0.04%
==========================================
Files 2224 2230 +6
Lines 65381 65459 +78
Branches 12357 12367 +10
==========================================
+ Hits 16158 16210 +52
- Misses 47898 47923 +25
- Partials 1325 1326 +1 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
libs/common/src/platform/state/state-event-registrar.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great!
Type of change
Objective
Add a
clearOn
key definition option so users can choose to have their state cleared on certain events. The option is not currently respected but will be in a follow up PR. This also scaffolds out the services that will be used to make this option work.Code changes
update
behave like the other fake stateupdate
methods.KeyDefinition
.SingleUserStateProvider
andActiveUserStateProvider
.Screenshots
Before you submit