Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bit-section component to SharedModule #8095

Merged
merged 1 commit into from
Feb 26, 2024
Merged

add bit-section component to SharedModule #8095

merged 1 commit into from
Feb 26, 2024

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Feb 26, 2024 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Add bit-section to web's SharedModule

(I forgot to do this in #8062.)

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@willmartian willmartian requested a review from a team as a code owner February 26, 2024 16:46
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Feb 26, 2024
dani-garcia
dani-garcia approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – f63b7a5b-cad8-4d6c-abc3-5c49146f0b74

No New Or Fixed Issues Found

@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label Feb 26, 2024
@willmartian willmartian merged commit 4cf911a into main Feb 26, 2024
28 of 30 checks passed
@willmartian willmartian deleted the ps/cl-export-section-comp branch February 26, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willmartian @bitwarden-bot @dani-garcia