Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6484] Updated CryptoService DI to use getBgService again #8146

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Feb 28, 2024

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Reverted the change in #7970 that updated CryptoService DI to remove the reliance on getBgService. This is still necessary until further state provider migrations are complete.

Code changes

  • services.module.ts: Added back use of getBgService.

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Feb 28, 2024
@trmartin4 trmartin4 changed the title Reverted change to CryptoService DI to use getBgService again Updated CryptoService DI to use getBgService again Feb 28, 2024
@trmartin4 trmartin4 marked this pull request as ready for review February 28, 2024 19:45
@trmartin4 trmartin4 removed the needs-qa Marks a PR as requiring QA approval label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 24.92%. Comparing base (ea0f5fa) to head (79d8b14).

Files Patch % Lines
apps/browser/src/popup/services/services.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8146   +/-   ##
=======================================
  Coverage   24.92%   24.92%           
=======================================
  Files        2239     2239           
  Lines       65597    65596    -1     
  Branches    12376    12376           
=======================================
  Hits        16347    16347           
+ Misses      47917    47916    -1     
  Partials     1333     1333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trmartin4 trmartin4 merged commit 745a0c9 into main Feb 28, 2024
24 of 27 checks passed
@trmartin4 trmartin4 deleted the auth/pm-6484/firefox-mp-reprompt branch February 28, 2024 21:08
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details612e5269-d831-4560-bee5-3ab576013eb1

No New Or Fixed Issues Found

@trmartin4 trmartin4 changed the title Updated CryptoService DI to use getBgService again [PM-6484] Updated CryptoService DI to use getBgService again Feb 28, 2024
trmartin4 added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants