Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change text for import data field in onboarding vault #8228

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Mar 6, 2024

Type of change

- [ X ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove logic for the import data text field. Keeping only the string If you don’t have any data to import, create a new item instead. Dynamic text logic will be applied in future ticket PM-5335

Screenshots

Screenshot 2024-03-06 at 12 54 51 PM

@Jingo88 Jingo88 requested a review from a team as a code owner March 6, 2024 17:55
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.29%. Comparing base (8e3a723) to head (464d416).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8228      +/-   ##
==========================================
+ Coverage   25.16%   25.29%   +0.13%     
==========================================
  Files        2250     2258       +8     
  Lines       65827    65926      +99     
  Branches    12412    12417       +5     
==========================================
+ Hits        16564    16679     +115     
+ Misses      47921    47902      -19     
- Partials     1342     1345       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jingo88 Jingo88 removed the needs-qa Marks a PR as requiring QA approval label Mar 6, 2024
@Jingo88 Jingo88 merged commit 356a155 into main Mar 6, 2024
34 of 35 checks passed
@Jingo88 Jingo88 deleted the PM-6643-Onboarding-import-text branch March 6, 2024 18:49
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details506a6066-1154-4d23-967e-7cf24539625d

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/background/runtime.background.ts: 317 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 388 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1280 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 361 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 426 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/background/runtime.background.ts: 317
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 342
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 377
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1251
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 409

cagonzalezcs pushed a commit that referenced this pull request Mar 7, 2024
change text for import data field in onboarding vault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants