Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-1840 - Remove default input for version #258

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

vgrassia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿšง Type of change

  • ๐Ÿ› Bug fix

๐Ÿ“” Objective

This PR removes the default value for the input version. This was causing the version to always be bumped to 2023.12.1 when not specifying a version.

๐Ÿ“‹ Code changes

  • version-bump/action.yml: Remove default key from input version.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Feb 29, 2024
@vgrassia vgrassia requested a review from a team as a code owner February 29, 2024 17:42
@vgrassia vgrassia enabled auto-merge (squash) February 29, 2024 17:43
@vgrassia vgrassia merged commit 4f37134 into main Feb 29, 2024
2 of 3 checks passed
@vgrassia vgrassia deleted the devops-1840_remove-default-version-input branch February 29, 2024 17:58
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 56ec82e8-bde9-40b6-a822-18bcc18d0ed4

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants