Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outputs tests to download artifact action tests #304

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

📔 Objective

Add outputs tests to download artifact action tests.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner September 5, 2024 11:49
Copy link

github-actions bot commented Sep 5, 2024

Logo
Checkmarx One – Scan Summary & Detailsf02b6eba-386b-46e0-bd04-135ae709cbca

No New Or Fixed Issues Found

@michalchecinski michalchecinski enabled auto-merge (squash) September 5, 2024 12:32
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@michalchecinski michalchecinski merged commit 7612451 into main Sep 5, 2024
4 checks passed
@michalchecinski michalchecinski deleted the extend-download-action-tests branch September 5, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants