Return Fido2VerificationException details to user

bitwarden · Nov 13, 2024 · 67fbded · 67fbded
1 parent 79e5d25
commit 67fbded
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/Service/Fido2Service.cs b/src/Service/Fido2Service.cs
@@ -398,7 +398,16 @@ public async Task<TokenResponse> SignInCompleteAsync(SignInCompleteDTO request,
             StoredSignatureCounter = credential.SignatureCounter,
             IsUserHandleOwnerOfCredentialIdCallback = callback
         };
-        var res = await fido2.MakeAssertionAsync(makeAssertionParams);
+        VerifyAssertionResult res;
+
+        try
+        {
+            res = await fido2.MakeAssertionAsync(makeAssertionParams);
+        }
+        catch (Fido2VerificationException fido2VerificationException)
+        {
+            throw new ApiException("signin_complete_error", fido2VerificationException.Message, 400);
+        }
 
         // Store the updated counter
         await _storage.UpdateCredential(res.CredentialId, res.SignCount, country, device);