Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject ISharedManagementService request scoped instead of transient. #597

Merged

Conversation

jonashendrickx
Copy link
Member

Description

Can potentially save a little bit of memory by injecting it request scoped instead of transient. ITenantStorage was also nowhere being referenced any longer.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • Verified everything was working properly.
  • Integration tests executed.

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner May 27, 2024 13:45
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.90%. Comparing base (b3b3318) to head (b35830b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   32.90%   32.90%   -0.01%     
==========================================
  Files         517      517              
  Lines       26187    26186       -1     
  Branches      774      774              
==========================================
- Hits         8617     8616       -1     
  Misses      17446    17446              
  Partials      124      124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 906b664 into main May 30, 2024
15 checks passed
@jonashendrickx jonashendrickx deleted the fix/optimize-memory-usage-shared-management-service branch May 30, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants