PAS-455 | Fix magic links for self-hosted instances #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Disables the magic links quota enforcement in a self-hosted environment, so that customers that spin up new instances can create new applications that are not the same as the admin e-mail that was used to setup Passwordless.dev for the first time.
Shape
When a new self-hosted instance is being spun up, you're being asked to enter your name and e-mail for the administrator account managing the Passwordless.dev self-hosted instance. But e-mails can only be sent out to the admin e-mails contained in the
adminconsole
application.If you then want to create a new organization using a different e-mail address than the one mentioned above, you cannot do so as there was a 24h period which only allows the initial admin to receive magic links.
In our cloud-hosted product, this is not a problem.
I personally would completely remove the quota enforcement defined
src/Service/MagicLinks/MagicLinkService
. As it causes a reverse dependency for the api to depend on the admin console.Screenshots
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: