Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-455 | Fix magic links for self-hosted instances #612

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jun 12, 2024

Ticket

Description

Disables the magic links quota enforcement in a self-hosted environment, so that customers that spin up new instances can create new applications that are not the same as the admin e-mail that was used to setup Passwordless.dev for the first time.

Shape

When a new self-hosted instance is being spun up, you're being asked to enter your name and e-mail for the administrator account managing the Passwordless.dev self-hosted instance. But e-mails can only be sent out to the admin e-mails contained in the adminconsole application.

If you then want to create a new organization using a different e-mail address than the one mentioned above, you cannot do so as there was a 24h period which only allows the initial admin to receive magic links.

In our cloud-hosted product, this is not a problem.

I personally would completely remove the quota enforcement defined src/Service/MagicLinks/MagicLinkService. As it causes a reverse dependency for the api to depend on the admin console.

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner June 12, 2024 09:25
@jonashendrickx jonashendrickx changed the title Fix magic links for self-hosted instances PAS-455 | Fix magic links for self-hosted instances Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.00%. Comparing base (04440ec) to head (a1aed9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   33.00%   33.00%           
=======================================
  Files         513      514    +1     
  Lines       26133    26131    -2     
  Branches      775      774    -1     
=======================================
+ Hits         8624     8625    +1     
+ Misses      17381    17378    -3     
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 2fbab91 into main Jun 12, 2024
15 checks passed
@jonashendrickx jonashendrickx deleted the PAS-455-Self-Hosted-sign-up-is-not-working-correctly-1.0.77-blocker branch June 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants