Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pas512-fix-playground-client #628

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jul 1, 2024

Ticket

Description

Fixed setting the alias to be used by the client in the playground. Fixed the purpose being passed to step up to use value instead of the raw ref.

Shape

Copy paste error resulting in an undefined alias and purpose not being set.

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • verified i could register, sign in and step up with an alias in the playground

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jrmccannon jrmccannon requested a review from a team as a code owner July 1, 2024 21:40
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.12%. Comparing base (31c7155) to head (b3ebeca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   34.12%   34.12%           
=======================================
  Files         534      534           
  Lines       27546    27546           
  Branches      807      807           
=======================================
  Hits         9400     9400           
  Misses      18015    18015           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccannon jrmccannon merged commit bd5513c into main Jul 2, 2024
15 checks passed
@jrmccannon jrmccannon deleted the pas512-fix-playground-client branch July 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants