Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-516 | Verified indices for ApiKeys, Aliases, Credentials #634

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jul 9, 2024

Ticket

Description

This pull request covers the indices for the hot code paths such as:

  • Private key and public key validation of incoming requests
  • Registration of passkeys
  • Signing in with and without aliases
  • Enumerating credentials

Shape

n/a

Screenshots

n/a

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner July 9, 2024 09:53
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 49.36842% with 481 lines in your changes missing coverage. Please review.

Project coverage is 34.62%. Comparing base (b66156e) to head (6df7c77).

Files Patch % Lines
...240709134121_AddIndicesForHotCodePaths.Designer.cs 0.00% 452 Missing ⚠️
.../Mssql/20240709134147_AddIndicesForHotCodePaths.cs 52.17% 11 Missing ⚠️
...Sqlite/20240709134121_AddIndicesForHotCodePaths.cs 0.00% 9 Missing ⚠️
...vice/Migrations/Mssql/MsSqlContextModelSnapshot.cs 0.00% 5 Missing ⚠️
...ce/Migrations/Sqlite/SqliteContextModelSnapshot.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   34.11%   34.62%   +0.51%     
==========================================
  Files         534      538       +4     
  Lines       27555    28502     +947     
  Branches      807      807              
==========================================
+ Hits         9401     9870     +469     
- Misses      18023    18501     +478     
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I will let the @bitwarden/team-passwordless-dev give the approval

@jonashendrickx jonashendrickx merged commit 8212280 into main Jul 21, 2024
15 checks passed
@jonashendrickx jonashendrickx deleted the PAS-516-Add-indices-to-our-db branch July 21, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants