Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-556 | Add support for credential hints to the register flow #670

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Aug 14, 2024

Ticket

Description

This adds an ability to provide credential hints to the /register endpoint.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • I used the Playground to verify that setting different hints results in different behavior

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@Tyrrrz Tyrrrz requested a review from a team as a code owner August 14, 2024 17:31
@Tyrrrz Tyrrrz changed the title Add support for credential hints to the register flow PAS-556 | Add support for credential hints to the register flow Aug 14, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 34.84%. Comparing base (4d08754) to head (e64329d).
Report is 3 commits behind head on main.

Files Patch % Lines
...nConsole/Pages/App/Playground/NewAccount.cshtml.cs 0.00% 9 Missing ⚠️
src/Service/TokenService.cs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   34.85%   34.84%   -0.01%     
==========================================
  Files         565      565              
  Lines       30945    30961      +16     
  Branches      923      924       +1     
==========================================
+ Hits        10785    10788       +3     
- Misses      20018    20031      +13     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz enabled auto-merge (squash) August 15, 2024 21:05
@Tyrrrz Tyrrrz merged commit 59cb8ba into main Aug 16, 2024
16 checks passed
@Tyrrrz Tyrrrz deleted the hints-register branch August 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants