Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-559 | Authorization handler is being executed concurrently. #673

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Aug 16, 2024

Ticket

Description

  1. We will need IDbContextFactory, this won't fix it permanently. Authorization handlers can be executed concurrently when Blazor/Razor components are being rendered.
  2. Adds the alias route '/signup' back for '/organization/create'

Shape

n/a

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner August 16, 2024 07:43
@jonashendrickx jonashendrickx changed the title PAS-559 PAS-559 | Failing synchronous call in authorization handler Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 34.83%. Comparing base (4d08754) to head (b622961).
Report is 1 commits behind head on main.

Files Patch % Lines
src/AdminConsole/Authorization/HasAppHandler.cs 0.00% 8 Missing ⚠️
...dminConsole/Middleware/CurrentContextMiddleware.cs 0.00% 6 Missing ⚠️
src/AdminConsole/Services/DataService.cs 0.00% 6 Missing ⚠️
src/AdminConsole/Program.cs 0.00% 1 Missing ⚠️
...dminConsole/Services/OrganizationFeatureService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   34.85%   34.83%   -0.02%     
==========================================
  Files         565      565              
  Lines       30945    30961      +16     
  Branches      923      924       +1     
==========================================
+ Hits        10785    10786       +1     
- Misses      20018    20033      +15     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx changed the title PAS-559 | Failing synchronous call in authorization handler PAS-559 | Authorization handler is being executed concurrently. Aug 16, 2024
@jonashendrickx jonashendrickx merged commit 2e94480 into main Aug 16, 2024
16 checks passed
@jonashendrickx jonashendrickx deleted the pas559 branch August 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants