Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait Strategy needs to be changed for TestContainers #692

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Aug 21, 2024

Description

After upgrading to Docker 4.33, I cannot get the integration tests to work on either Windows or Mac OS. This appears to work on both. There are some posts mentioning that the way we need to check for a ready SQL Server container has changed recently:

Confirmed to work on:

  • MacOS w/ Docker 4.32
  • MacOS w/ Docker 4.33
  • Windows 11 w/ Docker 4.33.1

Not working on:

  • Windows 11 w/ Docker 4.32

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner August 21, 2024 14:03
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.89%. Comparing base (74ed3d6) to head (b4ff02b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   34.89%   34.89%           
=======================================
  Files         566      566           
  Lines       31007    31007           
  Branches      936      936           
=======================================
  Hits        10819    10819           
  Misses      20043    20043           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 3591d04 into main Aug 21, 2024
16 checks passed
@jonashendrickx jonashendrickx deleted the testcontainers-wait-strategy-changed branch August 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants