Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-452 | Self-hosting and mailing bugs #707

Merged
merged 5 commits into from
Aug 29, 2024
Merged

PAS-452 | Self-hosting and mailing bugs #707

merged 5 commits into from
Aug 29, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Aug 29, 2024

Ticket

Description

  • Magic links or e-mails were failing to send.
  • Magic links or e-mails didn't have a correct displayed sender name.
  • Bootstrapping was broken when SSL was disabled. It will now work when we run with BWP_ENABLE_SSL set to false and the SSL certificates are provided by the load balancer such as Traefik.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner August 29, 2024 08:35
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (8697acd) to head (82d8c19).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Common/Services/Mail/Aws/AwsMailProvider.cs 0.00% 4 Missing ⚠️
src/Common/Services/Mail/AggregateMailProvider.cs 0.00% 1 Missing and 1 partial ⚠️
src/AdminConsole/Components/Pages/Initialize.razor 0.00% 1 Missing ⚠️
...wordlessManagement/PasswordlessManagementClient.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   35.15%   35.15%           
=======================================
  Files         574      574           
  Lines       31157    31158    +1     
  Branches      929      931    +2     
=======================================
+ Hits        10952    10953    +1     
+ Misses      20060    20059    -1     
- Partials      145      146    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 326f640 into main Aug 29, 2024
16 checks passed
@jonashendrickx jonashendrickx deleted the pas-452_bugs branch August 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants