Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing routing for when you click on Sidebar logo. #710

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jrmccannon
Copy link
Contributor

Description

When clicking on the logo, it would throw 500 because it couldn't find a Razor page for /Organization/Overview/. Changed this to a plain redirect since the overview page was migrated to blazor.

Shape

Changes LocalRedirect based off Razor Page to be Redirect.

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • Manually tested clicking the logo and ensured routing worked.

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • N/A

@jrmccannon jrmccannon requested a review from a team as a code owner August 30, 2024 16:43
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.14%. Comparing base (063515c) to head (5026fd6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/AdminConsole/Pages/Account/Login.cshtml.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   35.15%   35.14%   -0.01%     
==========================================
  Files         574      574              
  Lines       31156    31176      +20     
  Branches      930      930              
==========================================
+ Hits        10953    10958       +5     
- Misses      20057    20072      +15     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 9495330 into main Aug 30, 2024
16 checks passed
@jonashendrickx jonashendrickx deleted the fix-base-routing branch August 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants