[PM-3808] feat: add fido2 compatibility check before saving ciphers

bitwarden · Sep 11, 2023 · 97b87af · 97b87af
1 parent 938d380
commit 97b87af
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Api/Vault/Controllers/CiphersController.cs b/src/Api/Vault/Controllers/CiphersController.cs
@@ -27,6 +27,7 @@ namespace Bit.Api.Vault.Controllers;
 [Authorize("Application")]
 public class CiphersController : Controller
 {
+    private readonly Version _fido2KeyCipherMinimumVersion = new Version(Constants.Fido2KeyCipherMinimumVersion);
     private readonly ICipherRepository _cipherRepository;
     private readonly ICollectionCipherRepository _collectionCipherRepository;
     private readonly ICipherService _cipherService;
@@ -186,6 +187,13 @@ public async Task<CipherResponseModel> Put(Guid id, [FromBody] CipherRequestMode
                 "then try again.");
         }
 
+        var existingCipher = await _cipherRepository.GetByIdAsync(id, userId);
+        var existingCipherModel = new CipherResponseModel(existingCipher, _globalSettings);
+        if (existingCipherModel.Login?.Fido2Key != null && _currentContext.ClientVersion < _fido2KeyCipherMinimumVersion)
+        {
+            throw new BadRequestException("Please update your client to edit this item.");
+        }
+
         await _cipherService.SaveDetailsAsync(model.ToCipherDetails(cipher), userId, model.LastKnownRevisionDate, collectionIds);
 
         var response = new CipherResponseModel(cipher, _globalSettings);

diff --git a/src/Core/Constants.cs b/src/Core/Constants.cs
@@ -19,6 +19,7 @@ public static class Constants
     /// their subscription has expired.
     /// </summary>
     public const int OrganizationSelfHostSubscriptionGracePeriodDays = 60;
+    public const string Fido2KeyCipherMinimumVersion = "2023.9.0";
 }
 
 public static class TokenPurposes