Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the admin field from the config object #2252

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Remove the admin field from the config object #2252

merged 1 commit into from
Sep 8, 2022

Conversation

coltonhurst
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

We added the admin url in the config object as part of the new work adding a config endpoint to the API, but in hindsight we do not want to expose this url.

Code changes

  • ConfigResponseModel.cs: Removed the admin field in the EnvironmentConfigResponseModel and stopped setting it in the ConfigResponseModel constructor

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@coltonhurst coltonhurst marked this pull request as ready for review September 8, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants