[EC-449] Event log user for SCIM events #2306

r-tome · 2022-09-27T16:16:13Z

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Currently in the Event Log, SCIM events are captured under the user “Unknown”. The user should be “SCIM”.
These changes add a new column SystemUser to the Event table to store an Enum value EventSystemUser to store what kind of system was responsible for the event.
Updated EventResponse on the API to return the value for the SystemUser column.

Code changes

Related client changes on this PR.

bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: Passing SCIM value for EventSystemUser parameter to add to the event entry
bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: Passing SCIM value for EventSystemUser parameter to add to the event entry
src/Api/Controllers/OrganizationUsersController.cs: Added null value for EventSystemUser parameter
src/Api/Models/Response/EventResponseModel.cs: Added SystemUser column
src/Core/Entities/Event.cs: Added SystemUser column
src/Core/Enums/EventSystemUser.cs: Added SystemUser column
src/Core/Models/Data/EventMessage.cs: Added SystemUser column
src/Core/Models/Data/EventTableEntity.cs: Added SystemUser column
src/Core/Models/Data/IEvent.cs: Added SystemUser column
src/Core/Services/IEventService.cs: Added nullable parameter to log EventSystemUser
src/Core/Services/IGroupService.cs: Added nullable parameter to log EventSystemUser
src/Core/Services/IOrganizationService.cs: Added nullable parameter to log EventSystemUser
src/Core/Services/Implementations/EventService.cs: Added nullable parameter to log EventSystemUser
src/Core/Services/Implementations/GroupService.cs: Added nullable parameter to log EventSystemUser
src/Core/Services/Implementations/OrganizationService.cs: Added nullable parameter to log EventSystemUser
src/Core/Services/NoopImplementations/NoopEventService.cs: Updated method signatures for IEventService inheritance
src/Sql/dbo/Tables/Event.sql: Added column 'SystemUser' to 'Event' table
test/Core.Test/Services/OrganizationServiceTests.cs: Updated tests Log method signature
util/Migrator/DbScripts/2022-09-26_00_EventsSystemUser.sql: Migration to add column 'SystemUser' to 'Event' table
util/MySqlMigrations/Migrations/*: Migration to add column 'SystemUser' to 'Event' table
util/PostgresMigrations/Migrations/*: Migration to add column 'SystemUser' to 'Event' table

Before you submit

Please check for formatting errors (dotnet format --verify-no-changes) (required)
If making database changes - make sure you also update Entity Framework queries and/or migrations
Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team

…b.com/bitwarden/server into EC-449-event-log-user-for-scim-events

eliykat · 2022-09-29T05:37:13Z

@vincentsalucci was going to run this one past the other TPOCs. Let's hold off on a review until that's done in case there's a better way of doing this.

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-531] Implemented CQRS for Groups Put and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Update PutGroupCommand to return Group PutGroupCommand returns Group and GroupsController creates ScimGroupResponseModel response * [EC-507] Remove Queries/Commands folders from Scim and Scim.Tests * [EC-507] Remove unneeded check on empty provided memberIds

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-508] Implemented CQRS for Groups GetList and added unit tests * [EC-507] Created ScimServiceCollectionExtensions and renamed GetGroupsListCommand to GetGroupsListQuery * [EC-507] Renamed AddScimCommands to AddScimGroupQueries * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Remove 'Queries' folder from Scim and Scim.Test * [EC-507] Move ScimListResponseModel from GetGroupsListQuery to Scim.GroupsController * [EC-507] Remove asserts on IGroupRepository.GetManyByOrganizationIdAsync from unit tests

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-507] Implemented CQRS for Groups Get and added unit tests * [EC-507] Created ScimServiceCollectionExtensions and renamed GetGroupCommand to GetGroupQuery * [EC-507] Renamed AddScimCommands to AddScimGroupQueries * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Sorted order of methods * [EC-507] Removed GetGroupQuery and moved logic to controller * [EC-507] Remove 'Queries' folder from Scim and Scim.Test

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-532] Implemented CQRS for Groups Patch and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Remove Queries/Commands folders from Scim and Scim.Tests * [EC-507] Assert group.Name after saving. Assert userIds saved.

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-539] Implemented CQRS for Users Delete and added unit tests * [EC-508] Created ScimServiceCollectionExtensions * [EC-508] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-508] Removed unneeded model from DeleteUserCommand. Removed unneeded dependencies from UsersController * [EC-508] Removed Bit.Scim.Models dependency from DeleteUserCommandTests * [EC-508] Deleted 'DeleteUserCommand' from SCIM; Created commands on Core 'DeleteOrganizationUserCommand', 'PushDeleteUserRegistrationOrganizationCommand' and 'OrganizationHasConfirmedOwnersExceptQuery' * [EC-508] Changed DeleteOrganizationUserCommand back to using IOrganizationService * [EC-508] Fixed DeleteOrganizationUserCommand unit tests * [EC-508] Remove unneeded obsolete comments. Update DeleteUserAsync Obsolete comment with ticket reference * [EC-508] Move DeleteOrganizationUserCommand to OrganizationFeatures folder

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-536] Implemented CQRS for Users Post and added unit tests * [EC-508] Created ScimServiceCollectionExtensions * [EC-508] Renamed AddScimCommands to AddScimUserCommands * [EC-508] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-508] Catching NotFoundException on ExceptionHandlerFilter * [EC-508] Remove Queries/Commands folders from Scim and Scim.Tests

MGibson1

My only feedback on this is to try and avoid the nullable optional parameters.

Ideally these actions could be extracted to a few commands that would do that action and separately log an event (or have a base command that was implemented into two difference child commands).

src/Core/Services/Implementations/GroupService.cs

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-538] Implemented CQRS for Users Patch and added unit tests * [EC-508] Added ScimServiceCollectionExtensions * [EC-508] Removed HandleActiveOperationAsync method from UsersController * [EC-508] Renamed AddScimCommands to AddScimUserCommands * [EC-508] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-508] Removed unneeded dependencies from UsersController * [EC-508] Remove 'Query' folder from Scim and Scim.Test

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-530] Implemented CQRS for Groups Post and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Remove Queries/Commands folders from Scim and Scim.Test * [EC-507] Remove unneeded skipIfEmpty argument. Updated unit test to check provided userIds * [EC-507] Remove UpdateGroupMembersAsync from GroupsController

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-535] Implemented CQRS for Users GetList and added unit tests * [EC-508] Created ScimServiceCollectionExtensions and renamed GetUsersListCommand to GetUsersListQuery * [EC-508] Renamed AddScimCommands to AddScimUserQueries * [EC-508] Removed unneeded IUserRepository and IOptions<ScimSettings> from UsersController * [EC-508] Sorted UsersController properties and dependencies * [EC-508] Remove 'Queries' folder from Scim and Scim.Test * [EC-508] Move ScimListResponseModel creation to Scim.UsersController * [EC-508] Move ScimUserResponseModel creation to Scim.UsersController Co-authored-by: Thomas Rittson <trittson@bitwarden.com>

* [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-533] Implemented CQRS for Groups Delete and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Move DeleteGroupCommand to OrganizationFeatures/OrganizationUsers * [EC-507] Remove IGetUserQuery and move logic to UsersController. Remove unused references.

… accept EventSystemUser as an argument

…User param

…events # Conflicts: # bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs # bitwarden_license/src/Scim/Controllers/v2/UsersController.cs # src/Core/Services/IGroupService.cs

…events

eliykat

Nice one! It's getting there. I particularly like how we can pull the invitingUser and similar checks out of the private methods where it's not needed. I spotted a few other places we can do that.

src/Core/OrganizationFeatures/OrganizationUsers/DeleteOrganizationUserCommand.cs

src/Core/Services/Implementations/OrganizationService.cs

eliykat · 2022-10-30T23:04:07Z

src/Core/Services/Implementations/OrganizationService.cs

+        await _eventService.LogOrganizationUserEventAsync(orgUser, EventType.OrganizationUser_Removed, systemUser);
+    }
+
+    private async Task<OrganizationUser> RepositoryDeleteUserAsync(Guid organizationId, Guid organizationUserId, Guid? deletingUserId)


You can extract deletingUserId to the public method, similar to invitingUserId.

To do that I'd have to get the OrganizationUser first on each public method because one condition requires the User Type. I reckon it looks better as it is without the redundant call I'd have to make.

I think each public method making the repository call is fine, or I'd have the public methods require the OrganizationUser object to begin with. But we've done lots of refactoring already so we can leave it if you disagree.

src/Core/Services/Implementations/OrganizationService.cs

test/Core.Test/Services/OrganizationServiceTests.cs

# Conflicts: # bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs # bitwarden_license/src/Scim/Controllers/v2/UsersController.cs # bitwarden_license/src/Scim/Groups/PatchGroupCommand.cs # bitwarden_license/src/Scim/Groups/PostGroupCommand.cs # bitwarden_license/src/Scim/Groups/PutGroupCommand.cs # bitwarden_license/src/Scim/Users/PatchUserCommand.cs # bitwarden_license/src/Scim/Users/PostUserCommand.cs # bitwarden_license/test/Scim.Test/Groups/PatchGroupCommandTests.cs # bitwarden_license/test/Scim.Test/Groups/PostGroupCommandTests.cs # bitwarden_license/test/Scim.Test/Groups/PutGroupCommandTests.cs # bitwarden_license/test/Scim.Test/Users/PatchUserCommandTests.cs # bitwarden_license/test/Scim.Test/Users/PostUserCommandTests.cs # src/Core/OrganizationFeatures/Groups/DeleteGroupCommand.cs # src/Core/OrganizationFeatures/Groups/Interfaces/IDeleteGroupCommand.cs # src/Core/OrganizationFeatures/OrganizationUsers/DeleteOrganizationUserCommand.cs # src/Core/OrganizationFeatures/OrganizationUsers/Interfaces/IDeleteOrganizationUserCommand.cs # src/Core/Services/IGroupService.cs # test/Core.Test/OrganizationFeatures/Groups/DeleteGroupCommandTests.cs # test/Core.Test/OrganizationFeatures/OrganizationUsers/DeleteOrganizationUserCommandTests.cs

… single method

…nd Events list

src/Infrastructure.EntityFramework/Repositories/CipherRepository.cs

src/Core/Services/Implementations/OrganizationService.cs

eliykat

Great work!

This change has been made.

* [EC-449] Added new Enum EventSystemUser * [EC-449] Added SystemUser property to Event model * [EC-449] Added SQL migration to add new column 'SystemUserType' to Event * [EC-449] EF migrations * [EC-449] Added EventSystemUser to EventResponseModel * [EC-449] Saving EventSystemUser.SCIM on SCIM controller actions * [EC-449] Updated Event_Create stored procedure on Sql project * [EC-449] Fixed SystemUser column name on Event table * [EC-507] SCIM CQRS Refactor - Groups/Put (#2269) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-531] Implemented CQRS for Groups Put and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Update PutGroupCommand to return Group PutGroupCommand returns Group and GroupsController creates ScimGroupResponseModel response * [EC-507] Remove Queries/Commands folders from Scim and Scim.Tests * [EC-507] Remove unneeded check on empty provided memberIds * [EC-507] SCIM CQRS Refactor - Groups/GetList (#2272) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-508] Implemented CQRS for Groups GetList and added unit tests * [EC-507] Created ScimServiceCollectionExtensions and renamed GetGroupsListCommand to GetGroupsListQuery * [EC-507] Renamed AddScimCommands to AddScimGroupQueries * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Remove 'Queries' folder from Scim and Scim.Test * [EC-507] Move ScimListResponseModel from GetGroupsListQuery to Scim.GroupsController * [EC-507] Remove asserts on IGroupRepository.GetManyByOrganizationIdAsync from unit tests * [EC-507] SCIM CQRS Refactor - Groups/Get (#2271) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-507] Implemented CQRS for Groups Get and added unit tests * [EC-507] Created ScimServiceCollectionExtensions and renamed GetGroupCommand to GetGroupQuery * [EC-507] Renamed AddScimCommands to AddScimGroupQueries * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Sorted order of methods * [EC-507] Removed GetGroupQuery and moved logic to controller * [EC-507] Remove 'Queries' folder from Scim and Scim.Test * [EC-507] SCIM CQRS Refactor - Groups/Patch (#2268) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-532] Implemented CQRS for Groups Patch and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Remove Queries/Commands folders from Scim and Scim.Tests * [EC-507] Assert group.Name after saving. Assert userIds saved. * [EC-508] SCIM CQRS Refactor - Users/Delete (#2261) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-539] Implemented CQRS for Users Delete and added unit tests * [EC-508] Created ScimServiceCollectionExtensions * [EC-508] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-508] Removed unneeded model from DeleteUserCommand. Removed unneeded dependencies from UsersController * [EC-508] Removed Bit.Scim.Models dependency from DeleteUserCommandTests * [EC-508] Deleted 'DeleteUserCommand' from SCIM; Created commands on Core 'DeleteOrganizationUserCommand', 'PushDeleteUserRegistrationOrganizationCommand' and 'OrganizationHasConfirmedOwnersExceptQuery' * [EC-508] Changed DeleteOrganizationUserCommand back to using IOrganizationService * [EC-508] Fixed DeleteOrganizationUserCommand unit tests * [EC-508] Remove unneeded obsolete comments. Update DeleteUserAsync Obsolete comment with ticket reference * [EC-508] Move DeleteOrganizationUserCommand to OrganizationFeatures folder * [EC-508] SCIM CQRS Refactor - Users/Post (#2264) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-536] Implemented CQRS for Users Post and added unit tests * [EC-508] Created ScimServiceCollectionExtensions * [EC-508] Renamed AddScimCommands to AddScimUserCommands * [EC-508] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-508] Catching NotFoundException on ExceptionHandlerFilter * [EC-508] Remove Queries/Commands folders from Scim and Scim.Tests * [EC-508] SCIM CQRS Refactor - Users/Patch (#2262) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-538] Implemented CQRS for Users Patch and added unit tests * [EC-508] Added ScimServiceCollectionExtensions * [EC-508] Removed HandleActiveOperationAsync method from UsersController * [EC-508] Renamed AddScimCommands to AddScimUserCommands * [EC-508] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-508] Removed unneeded dependencies from UsersController * [EC-508] Remove 'Query' folder from Scim and Scim.Test * [EC-507] SCIM CQRS Refactor - Groups/Post (#2270) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-530] Implemented CQRS for Groups Post and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Remove Queries/Commands folders from Scim and Scim.Test * [EC-507] Remove unneeded skipIfEmpty argument. Updated unit test to check provided userIds * [EC-507] Remove UpdateGroupMembersAsync from GroupsController * [EC-508] SCIM CQRS Refactor - Users/GetList (#2265) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-535] Implemented CQRS for Users GetList and added unit tests * [EC-508] Created ScimServiceCollectionExtensions and renamed GetUsersListCommand to GetUsersListQuery * [EC-508] Renamed AddScimCommands to AddScimUserQueries * [EC-508] Removed unneeded IUserRepository and IOptions<ScimSettings> from UsersController * [EC-508] Sorted UsersController properties and dependencies * [EC-508] Remove 'Queries' folder from Scim and Scim.Test * [EC-508] Move ScimListResponseModel creation to Scim.UsersController * [EC-508] Move ScimUserResponseModel creation to Scim.UsersController Co-authored-by: Thomas Rittson <trittson@bitwarden.com> * [EC-507] SCIM CQRS Refactor - Groups/Delete (#2267) * [EC-390] Added Scim.Test unit tests project * [EC-390] Added ConflictException type. Updated BadRequestException to have parameterless constructor. Updated NotFoundException to have constructor with a message parameter * [EC-533] Implemented CQRS for Groups Delete and added unit tests * [EC-507] Created ScimServiceCollectionExtensions * [EC-507] Renamed AddScimCommands to AddScimGroupCommands * [EC-507] Created ExceptionHandlerFilterAttribute on SCIM project * [EC-507] Removed unneeded dependencies from GroupsController * [EC-507] Move DeleteGroupCommand to OrganizationFeatures/OrganizationUsers * [EC-507] Remove IGetUserQuery and move logic to UsersController. Remove unused references. * [EC-449] Add overloads for EventService and GroupService methods that accept EventSystemUser as an argument * [EC-507] Move IDeleteGroupCommand to Groups folder * [EC-449] Add method overloads in IOrganizationService without EventSystemUser * [EC-449] Add RevokeUserAsync overload without EventSystemUser * [EC-449] Reverted OrganizationUsersController to not pass EventSystemUser argument * [EC-449] Uncomment assertion in GroupServiceTests * [EC-449] Update method overloads to not have nullable EventSystemUser * [EC-449] Add unit tests around events that can store EventSystemUser * [EC-449] Deleted private method GroupService.GroupRepositoryDeleteAsync * [EC-449] Move Event log call to public DeleteUserAsync methods * [EC-449] Move call to EventService log to public OrganizationService.InviteUsersAsync methods * [EC-449] Move EventService call to public OrganizationService.DeleteUserAsync methods * [EC-449] Move EventService call to OrganizationService.RevokeUserAsync methods * [EC-449] Move EventService call to OrganizationService.RestoreUserAsync methods * [EC-449] Add missing comma in SQL script for new SystemUser column on the Event table * [EC-449] Remove Autofixture hack from OrganizationServiceTests * [EC-449] Remove invitingUser param when methods expect an EventSystemUser param * [EC-449] Move DeleteUserAsync validation to private method * [EC-449] Move revokingUserId from RevokeUserAsync private method * [EC-449] Move restoringUserId to RestoreUserAsync public method * [EC-449] Set up OrganizationServiceTest Restore and Revoke tests on a single method * [EC-449] SaveUsersSendInvitesAsync to return both OrganizationUsers and Events list * [EC-449] Undo unintended change on CipherRepository * [EC-449] Add SystemUser value to EventTableEntity Co-authored-by: Thomas Rittson <trittson@bitwarden.com> (cherry picked from commit 37ed4f4)

r-tome and others added 10 commits September 27, 2022 16:49

[EC-449] Added new Enum EventSystemUser

1c1e193

[EC-449] Added SystemUser property to Event model

df5db9f

[EC-449] Added SQL migration to add new column 'SystemUserType' to Event

1fa9405

[EC-449] EF migrations

2fc8544

[EC-449] Added EventSystemUser to EventResponseModel

2870069

[EC-449] Saving EventSystemUser.SCIM on SCIM controller actions

043ebb3

Merge branch 'master' into EC-449-event-log-user-for-scim-events

3f6b2a9

[EC-449] Updated Event_Create stored procedure on Sql project

b6f09de

Merge branch 'EC-449-event-log-user-for-scim-events' of https://githu…

5e526ed

…b.com/bitwarden/server into EC-449-event-log-user-for-scim-events

[EC-449] Fixed SystemUser column name on Event table

e1a1c8c

r-tome marked this pull request as ready for review September 28, 2022 14:01

r-tome requested a review from a team September 28, 2022 14:01

r-tome mentioned this pull request Sep 28, 2022

[EC-449] Event log user for SCIM events bitwarden/clients#3643

Merged

r-tome added 6 commits October 17, 2022 12:49

MGibson1 requested changes Oct 17, 2022

View reviewed changes

src/Core/Services/Implementations/GroupService.cs Outdated Show resolved Hide resolved

r-tome and others added 9 commits October 18, 2022 10:27

Merge branch 'master' into EC-449-event-log-user-for-scim-events

2fa17f4

[EC-449] Add overloads for EventService and GroupService methods that…

e0ff808

… accept EventSystemUser as an argument

Merge branch 'master' into feature/scim-cqrs

659feb5

[EC-507] Move IDeleteGroupCommand to Groups folder

4936012

Merge branch 'master' into feature/scim-cqrs

8f37a51

r-tome added 2 commits October 28, 2022 15:43

[EC-449] Remove invitingUser param when methods expect an EventSystem…

cd6f7c0

…User param

Merge branch 'feature/scim-cqrs' into EC-449-event-log-user-for-scim-…

d3c6999

…events # Conflicts: # bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs # bitwarden_license/src/Scim/Controllers/v2/UsersController.cs # src/Core/Services/IGroupService.cs

r-tome changed the base branch from master to feature/scim-cqrs October 28, 2022 15:35

eliykat added 2 commits October 31, 2022 08:32

Merge remote-tracking branch 'origin/master' into feature/scim-cqrs

fc6adb7

Merge branch 'feature/scim-cqrs' into EC-449-event-log-user-for-scim-…

0107416

…events

eliykat requested changes Oct 30, 2022

View reviewed changes

Base automatically changed from feature/scim-cqrs to master October 31, 2022 09:58

r-tome added 6 commits October 31, 2022 11:09

[EC-449] Move DeleteUserAsync validation to private method

c69bfbd

[EC-449] Move revokingUserId from RevokeUserAsync private method

caeb333

[EC-449] Move restoringUserId to RestoreUserAsync public method

bac325c

[EC-449] Set up OrganizationServiceTest Restore and Revoke tests on a…

c66e305

… single method

[EC-449] SaveUsersSendInvitesAsync to return both OrganizationUsers a…

aad961b

…nd Events list

r-tome requested a review from eliykat October 31, 2022 17:17

Merge branch 'master' into EC-449-event-log-user-for-scim-events

a3a5092

eliykat reviewed Nov 1, 2022

View reviewed changes

src/Infrastructure.EntityFramework/Repositories/CipherRepository.cs Outdated Show resolved Hide resolved

src/Core/Services/Implementations/OrganizationService.cs Outdated Show resolved Hide resolved

r-tome and others added 3 commits November 1, 2022 08:16

[EC-449] Undo unintended change on CipherRepository

0dc6ffb

[EC-449] Add SystemUser value to EventTableEntity

9760044

Merge branch 'master' into EC-449-event-log-user-for-scim-events

93ac9d4

r-tome requested a review from eliykat November 2, 2022 09:36

eliykat approved these changes Nov 2, 2022

View reviewed changes

r-tome added the needs-qa label Nov 2, 2022

MGibson1 removed their request for review November 2, 2022 14:51

r-tome removed the needs-qa label Nov 9, 2022

Merge branch 'master' into EC-449-event-log-user-for-scim-events

f4ab101

r-tome merged commit 37ed4f4 into master Nov 9, 2022

r-tome deleted the EC-449-event-log-user-for-scim-events branch November 9, 2022 12:13

r-tome mentioned this pull request Nov 15, 2022

[EC-756] Add missing EF scripts to add new 'Events' table 'SystemUser' column #2414

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EC-449] Event log user for SCIM events #2306

[EC-449] Event log user for SCIM events #2306

r-tome commented Sep 27, 2022 •

edited

Loading

eliykat commented Sep 29, 2022

MGibson1 left a comment

eliykat left a comment

eliykat Oct 30, 2022

r-tome Oct 31, 2022 •

edited

Loading

eliykat Nov 1, 2022 •

edited

Loading

eliykat left a comment

[EC-449] Event log user for SCIM events #2306

[EC-449] Event log user for SCIM events #2306

Conversation

r-tome commented Sep 27, 2022 • edited Loading

Type of change

Objective

Code changes

Before you submit

eliykat commented Sep 29, 2022

MGibson1 left a comment

Choose a reason for hiding this comment

eliykat left a comment

Choose a reason for hiding this comment

eliykat Oct 30, 2022

Choose a reason for hiding this comment

r-tome Oct 31, 2022 • edited Loading

Choose a reason for hiding this comment

eliykat Nov 1, 2022 • edited Loading

Choose a reason for hiding this comment

eliykat left a comment

Choose a reason for hiding this comment

r-tome commented Sep 27, 2022 •

edited

Loading

r-tome Oct 31, 2022 •

edited

Loading

eliykat Nov 1, 2022 •

edited

Loading