Delete OrgUsers When Deleting An Org #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kspearrin
requested changes
Oct 9, 2020
| DELETE | ||
| FROM | ||
| [dbo].[OrganizationUser] | ||
| WHERE [OrganizationId] = @Id |
There was a problem hiding this comment.
where condition on new line like others
| @@ -37,11 +37,24 @@ BEGIN | |||
| WHERE | |||
| [OrganizationId] = @Id | |||
|
|
|||
| DELETE cu | |||
There was a problem hiding this comment.
i think we use upper case for these abbreviations
kspearrin
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 🕷
Currently deleting an organization leaves some orphaned data in CollectionUser and OrganizationUser records.
This may have never been an issue before, but now it is causing problems with the OnlyOrg policy. If an organization has OnlyOrg enabled anyone that may have been left orphaned by a deleted organization can not join the org because an OrgUser record still exists for them from the deleted org.
Fix 🔨
Delete OrgUser records and CollectionUser records when deleting an organization