Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: fix gridline tests for np 2.x #998

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Jul 14, 2024

🚀 Pull Request

Description

Now that pyvista 0.44 is released with numpy 2.x support 🥳, it made it easy to investigate and propose the simple fix to address the failing geovista.gridlines tests.

Essentially, numpy 2.x was injecting the scalar type for the __repr__ used in the multi-blocks keys. We can safely remove this to make geovista work with both numpy 1.x and 2.x.

Closes #849

N.B., there appears to be some optional geovista dependencies holding back conda resolving the environment with numpy 2.x ... but that will untangle itself in the fullness of time, and isn't a blocker.


@github-actions github-actions bot added the type: bug Auto-labelled for bug/*, fix/* and patch/* branches label Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (26b3a74) to head (4697148).
Report is 2 commits behind head on v0.5.x.

Additional details and impacted files
@@           Coverage Diff           @@
##           v0.5.x     #998   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          58       58           
  Lines        2934     2934           
=======================================
  Hits         2679     2679           
  Misses        255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit 57fc7ed into v0.5.x Jul 14, 2024
24 checks passed
@bjlittle bjlittle deleted the patch-gridlines-multiblock branch July 14, 2024 22:01
bjlittle added a commit that referenced this pull request Oct 3, 2024
* patch: fix gridline tests for np 2.x (#998)

* patch: fix rasterio 1.4.x regression (#1132)

* patch: fix rasterio 1.4.x regression

* remove broken link (#1065)

* fix upload coverage (#1075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scipy 2024 type: bug Auto-labelled for bug/*, fix/* and patch/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant