patch: fix gridline tests for np 2.x #998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Now that
pyvista
0.44 is released withnumpy
2.x support 🥳, it made it easy to investigate and propose the simple fix to address the failinggeovista.gridlines
tests.Essentially,
numpy
2.x was injecting the scalar type for the__repr__
used in the multi-blocks keys. We can safely remove this to makegeovista
work with bothnumpy
1.x and 2.x.Closes #849
N.B., there appears to be some optional
geovista
dependencies holding backconda
resolving the environment withnumpy
2.x ... but that will untangle itself in the fullness of time, and isn't a blocker.