Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve cyclic import between fs_core.ts <-> fs_fd.ts #60

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: Resolve cyclic import between fs_core.ts <-> fs_fd.ts #60

merged 1 commit into from
Dec 14, 2023

Conversation

kateinoigakukun
Copy link
Contributor

Close #58

@bjorn3 bjorn3 merged commit e588476 into bjorn3:main Dec 14, 2023
1 check passed
@kateinoigakukun
Copy link
Contributor Author

Thanks :)

@bjorn3
Copy link
Owner

bjorn3 commented Dec 14, 2023

I just saw ruby/ruby.wasm#332. Looks cool! Do you need a new release or are there still some issues you need fixed first?

@kateinoigakukun kateinoigakukun deleted the katei/resolve-import-cycle branch December 14, 2023 13:10
@kateinoigakukun
Copy link
Contributor Author

All blockers are now fixed! A new release would be appreciated 😄

@bjorn3
Copy link
Owner

bjorn3 commented Dec 14, 2023

Done as v0.2.17.

@kateinoigakukun
Copy link
Contributor Author

Thanks a lot!

@kateinoigakukun
Copy link
Contributor Author

Just FYI: We released ruby.wasm 2.4.0 and it now uses @bjorn3/browser_wasi_shim as default WASI impl for browser. Thank you for your all work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circular dependency between fs_core.ts <-> fs_fd.ts
2 participants
@kateinoigakukun @bjorn3