Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiMap: pass config object to child maps #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TehShrike
Copy link

Allowing you to pass, among other things, a data series to child maps.

Allowing you to pass, among other things, a data series to child maps.
@TehShrike
Copy link
Author

Resolves #311

@RockyRx
Copy link

RockyRx commented Jan 23, 2017

Why this isn't merged yet? Is there any other solution?

@fab120
Copy link

fab120 commented Jan 23, 2017

@RockyRx Look at the code.. This project is not under active development right now and the last commit is 2 years old.
So if you want modify the source, you must do it by yourself by forking this project.
If this is the only patch that you need, you can use this version on my repo:
https://github.com/Webnuvola/jvectormap
It has this pr and an additional parameter 'backButtonText' for the multimap object.

@RockyRx
Copy link

RockyRx commented Jan 23, 2017

@fab120 thanks for the update.

@RockyRx
Copy link

RockyRx commented Jan 23, 2017

@fab120 I cloned your repo and build it via build.sh and added subMapsOptions: { onRegionClick: function (event, code) { console.log(code); } },
But I do not see anything on my console. Did I do something wrong?

@fab120
Copy link

fab120 commented Jan 23, 2017

Where is the option 'subMapsOptions' in documentation?

This pr clone the config of the multimap object to the submap. Nothing more.
https://github.com/bjornd/jvectormap/pull/362/files#diff-c635a4d3a687d84bab176e0f79d22175R106

The config is taken from the object that you pass as the main parameter
http://jvectormap.com/documentation/javascript-api/jvm-multimap/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants