Fixing Wayland cmake definitions and linkage #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtytel
changed the title
|
So 'Linux' actually wasn't matching CMAKE_SYSTEM_NAME and removing the single quotes makes it match so it turned on WAYLAND by default in the build above. That exposed some missing definitions and library linkage so I've fixed that here. I also turned off wayland by default which is how it was behaving originally (because it never matched 'Linux') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer versions of cmake this line triggers a CMP0127 warning. Removing the quotes because they're not needed in older versions of cmake and doesn't trigger the warning in newer version of cmake.