Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-ppc64le-clang profile #292

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

runlevel5
Copy link
Contributor

For Linux distros that use clang over gcc for game development

Changes

  • Add linux-ppc64le-clang profile
  • Add makefile target for both gcc and clang profiles

@bkaradzic
Copy link
Owner

Can you add all changes for PPC at once? Is this the last change or there is more?

@bkaradzic
Copy link
Owner

Another thing here is that PPC is very uncommon platform. It's like you, and maybe there is some other dude that also uses Haiku as his OS. :) And we already have 2 configurations for this platform that only maybe 2 people in the world will use.

@runlevel5
Copy link
Contributor Author

runlevel5 commented Nov 15, 2022

Can you add all changes for PPC at once? Is this the last change or there is more?

In consideration of your time, I try to break the change into manageable PRs that are easy for you to review. As of now, this is the last change.

Another thing here is that PPC is very uncommon platform. It's like you, and maybe there is some other dude that also uses Haiku as his OS. :) And we already have 2 configurations for this platform that only maybe 2 people in the world will use.

Understood. The PPC community though is small but quite active. With support from IBM / Red Hat there has been lots of progress and development within the community.

@runlevel5
Copy link
Contributor Author

@bkaradzic please hold reviewing this PR. Thanks for your response in bkaradzic/GENie#550 (comment), I will make one more change to use lld with clang profile

@runlevel5
Copy link
Contributor Author

@bkaradzic I could not figure out how to set linker to ldd with premake.gcc, let's stay with the ld for this PR. Therefore the PR is ready for review. Great thanks

@bkaradzic
Copy link
Owner

Looks fine, just remove changes from makefile. It's intended more for common path for most of users. PPC user could just invoke GENie and make themselves.

@runlevel5
Copy link
Contributor Author

@bkaradzic yes I have removed all changes from makefile

@bkaradzic bkaradzic merged commit aed1086 into bkaradzic:master Nov 16, 2022
@runlevel5 runlevel5 deleted the clang-ppc64le branch November 16, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants