Fix dev-dependencies scan if target.XYZ clause also has dependencies
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
target.XYZ clause also has dependenciesdev-dependencies scan if target.XYZ clause also has dependencies
…cies` In the event that a `dependencies` table exists in addition to the `dev-dependencies` table with the same `target.XYZ` clause, only the `dependencies` table would get read when we instead desire both. Fixes: c2a4c91 ("Also walk `target.'cfg()'` for `dev-dependencies` next to `dependencies`")
MarijnS95
force-pushed
the
dev-dependencies
branch
from
5a4b446
to
05c653d
Compare
bkchr
approved these changes
Feb 16, 2022
|
No problem. I should have reviewed it better :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a
dependenciestable exists in addition to thedev-dependenciestable with the sametarget.XYZclause, only thedependenciestable would get read when we instead desire both.Fixes: c2a4c91 ("Also walk
target.'cfg()'fordev-dependenciesnext todependencies")