Feature/261 groups #327
Merged
Feature/261 groups #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spahrson
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Ich habe das getestet und es funktioniert m.E. wie gewünscht.
Mir ist noch was anderes aufgefallen: Wenn eine Gruppe für die Anzeige ausgewählt ist, wird trotzdem für alle Schüler die Absenzen anderer Lehrkräfte geladen werden. Das könnte man noch einschränken, falls die ein Perfomance-Issue darstellt. Funktional ist es kein Probelm. Jedoch würde ich das als separate Story sehen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Die Punkte aus folgenden Kommentaren sollten mit diesem Change behoben sein:
Desweiteren habe ich noch herausgefunden, dass eine Lektion nicht mehrere EventIds haben kann (#261 (comment)). Das hat auch noch zu einer Anpassung geführt.