Optionale GradingScaleID für Kurse #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mburri
force-pushed
the
feature/428-optional-grading-scaleid
branch
from
e2ff539 to
cb24e4b
Compare
caebr
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Die GradingsScaleId kann leer sein - Beispiel sie #428
Das zieht eine Reihe von Null-Checks nach sich - ich gehe jetzt davon aus, dass man den Kurs nicht in einen Status zum Erfassen von Noten überführen kann, wenn keine GradingScale vorhanden ist - ich kann aber nicht wirklich abschätzen was in dem Fall mit der aktuellen Implementation passieren würde... aktuell haben wir das jetzt nicht.
Ich habe es jetzt so gelöst, dass in diesem Fall eine GradingScale zusammengestellt wird mit
id = -1und einer leeren Liste von Options.