add conditional request support to polling #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as described in https://developer.github.com/v3/#conditional-requests by using etags, we allow github to return '304 not modified' responses, which don't count against our rate limit. This should help fix the rate limit issue we discovered tonight.
|
@pangaunn this PR should help with the rate limit issue we found. Maybe we won't need a server-side fix with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://developer.github.com/v3/#conditional-requests
By using etags, we allow github to return '304 not modified' responses, which don't count against our rate limit. This should help fix the ratelimit issue we discovered tonight.