Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork release/staging #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fork release/staging #12

wants to merge 5 commits into from

Conversation

bkyryliuk
Copy link
Owner

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

bkyryliuk and others added 5 commits June 23, 2020 14:23
@bkyryliuk @bogdan-dbx
Let users know that time is in UTC (#15)
bddb9ce 
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
@bkyryliuk @bogdan-dbx
Add a single endpoint that visualizes new table. [Hivepad itegration] (…
8fd37eb 
…#6)

* Create additional endpoint that vizualized the new table

* Unit tests

* Use proper schema depending on the engine
@bogdan-dbx
Implement create view as functionality
e8eeffc 
Implement create view as button in sqllab

Make CVAS configurable
@bogdan-dbx
Update gitignore for release
e34acb5
@bogdan-dbx
Generate js assets
bde0c3b
@github-actions
Copy link

WARNING: Prefer TypeScript

It looks like your PR contains new .js or .jsx files. As decided in SIP-36, all new files should be written in TypeScript. Please convert new JavaScript files to TypeScript and then re-request review.

@github-actions
Copy link

⚠️ @bkyryliuk Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

3 similar comments
@github-actions
Copy link

⚠️ @bkyryliuk Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

@bkyryliuk
Copy link
Owner Author

⚠️ @bkyryliuk Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

@github-actions
Copy link

⚠️ @bkyryliuk Your base branch master has just also updated superset/migrations.

❗ Please consider rebasing your branch to avoid db migration conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkyryliuk @bogdan-dbx