-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode paths, Static analysis, Update Libs, Fix typos #191
Open
black-sliver
wants to merge
19
commits into
master
Choose a base branch
from
refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
black-sliver
commented
Nov 2, 2024
•
edited
Loading
edited
- update miniz, tinyfd, json and valijson libs
- use std::filesystem (or boost::filesystem) and use utf8 strings on windows for miniz, openssl and sdl for full unicode support
- adds test for unicode support
- add github action for scan-build static analysis
- fix some minor things that were found by scan-build
- fix some warnings
- fix some typos and add codespell action
- document and enable ASAN for CI where possible
- some UI fixes
- those still need to be tested
black-sliver
force-pushed
the
refactor
branch
from
November 3, 2024 13:15
5cd4b87
to
74d0d63
Compare
black-sliver
changed the title
Unicode paths, Static analysis, Update Libs
Unicode paths, Static analysis, Update Libs, Fix typos
Nov 3, 2024
black-sliver
force-pushed
the
refactor
branch
6 times, most recently
from
November 5, 2024 07:37
6577302
to
c6e79aa
Compare
also update miniz miniz expects utf8 on windows now SDL2 already expected utf8 on windows, which may have been handled poorly before
and fix some issues found
Fix typos
and document it
black-sliver
force-pushed
the
refactor
branch
from
November 5, 2024 07:40
c6e79aa
to
7946771
Compare
This works around layouts with no h-grow not properly shrinking the window.
This works around children with no h-grow not updating their parents' size. The if is required because minSize does not always properly populate now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.