fix encoding #62
Closed
fix encoding #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have to add encoding="utf-8") when loading emoji.json file while running your pkg on windows |
blackary
reviewed
Sep 5, 2023
blackary
reviewed
Sep 5, 2023
|
I comment it out while testing my change and forgot to put it back.
…On Tue, Sep 5, 2023 at 10:36 AM Zachary Blackwood ***@***.***> wrote:
***@***.**** commented on this pull request.
Is there a reason you removed cache_resource? Does that cause issues for
you?
—
Reply to this email directly, view it on GitHub
<#62 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQRSFNVTNQ6L3AC7RIJWDXY42IXANCNFSM6AAAAAA4JQAGAY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Thanks,
Wen
|
blackary
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Please undo this change -- this is necessary for the demo app.
blackary
reviewed
Sep 6, 2023
blackary
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Please remove these from the PR :)
blackary
reviewed
Sep 6, 2023
There was a problem hiding this comment.
All these demos aren't necessary, as the example_app folder already exists. You can test it by running streamlit run example_app/streamlit_app.py
|
Change added in #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have to add
encoding="utf-8")when loading emoji.json file