Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editable vanilla table columns #57

Closed
wants to merge 63 commits into from
Closed

editable vanilla table columns #57

wants to merge 63 commits into from

Conversation

GamerGirlandCo
Copy link
Collaborator

i also added some editable components and helper methods to the local api.

p.s.: let me know if i should take care of Table.tsx too.

@GamerGirlandCo GamerGirlandCo marked this pull request as ready for review July 14, 2024 22:31
@GamerGirlandCo GamerGirlandCo force-pushed the feat/editable-vanilla-columns branch 3 times, most recently from feddd3e to ab55316 Compare July 20, 2024 19:20
@GamerGirlandCo GamerGirlandCo force-pushed the feat/editable-vanilla-columns branch 3 times, most recently from 2b68a86 to 732dd81 Compare October 3, 2024 01:17
@GamerGirlandCo GamerGirlandCo force-pushed the feat/editable-vanilla-columns branch 15 times, most recently from 9396c70 to c9d0c5e Compare October 22, 2024 02:55
@GamerGirlandCo GamerGirlandCo changed the base branch from master to feat/tasks October 22, 2024 18:17
@GamerGirlandCo
(task component) wrap editableFields in useMemo
f49fbfa
@GamerGirlandCo
(task component) remove hacky dispatch and state (i figured everythin…
d75d9cb 
…g out 🎉)
@GamerGirlandCo
- update html structure of task item content
a6cfc11 
- allow default value of displayed field to be a function
- set field updater to a stable callback
@GamerGirlandCo
update setTaskCompletion to set/unset the appropriate $infields sub…
863aeb2 
…property
@GamerGirlandCo
improve editable field updater
7275b3d
@GamerGirlandCo
improve date detection in task field editing
7fd355a
@GamerGirlandCo
make updater prop non-optional, rename props
d39a78b
@GamerGirlandCo
misc task improvements
0f3e566
@GamerGirlandCo
de-memoize editable task fields
927f0de
@GamerGirlandCo
add text field to list item type
7676495
@GamerGirlandCo
list item improvements
4e9cbdc 
(cherry picked from commit 97c385c3a50858334135717ea66b472fa23355f9)
@GamerGirlandCo
fix imports
1d32a3f
@GamerGirlandCo
move task.tsx to appropriate place
ce7b7fa
@GamerGirlandCo
fix more imports
bbe603f
@GamerGirlandCo
run format
7970597
@GamerGirlandCo
incorporate ScriptCache into local api
40afebe
@GamerGirlandCo
move src/ui/utils to src/utils/task
f0aed8d
@GamerGirlandCo
Squashed commit of the following:
878226a 
commit 881a6e6
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 15:57:01 2024 -0500

    Auto-release beta 0.1.14

commit 74e4c49
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 15:56:36 2024 -0500

    Fix generic file loading

commit c2ca088
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 15:38:20 2024 -0500

    Fix Link.markdown()

commit e61b780
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 15:30:15 2024 -0500

    Auto-release beta 0.1.13

commit 5bba27c
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 15:29:56 2024 -0500

    Fix importing tags from 'tags' frontmatter

commit e3d1d40
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 00:45:52 2024 -0500

    Auto-release beta 0.1.12

commit 1521445
Author: Michael Brenan <michael@brenan.dev>
Date:   Wed Jul 3 00:45:23 2024 -0500

    Add crappy loading loading boundary + script loader to all views

commit 98ea006
Author: Michael Brenan <michael@brenan.dev>
Date:   Tue Jul 2 18:44:34 2024 -0500

    Auto-release beta 0.1.11

commit 4f5d9f0
Author: Michael Brenan <michael@brenan.dev>
Date:   Tue Jul 2 18:44:00 2024 -0500

    Add some more docs and fix some missing returns

commit 367efeb
Author: Michael Brenan <michael@brenan.dev>
Date:   Tue Jul 2 18:32:14 2024 -0500

    Add support for JS files to require, improve some statefulness, a few more error messages

commit b188cb7
Author: ☙◦ The Tablet ❀ GamerGirlandCo ◦❧ <i.am.the.tablet@proton.me>
Date:   Tue Jul 2 03:52:07 2024 -0400

    `dc.require` functionality for importing other scripts (#49)

    * make `DatacoreJSRenderer.convert` static since it doesn't use instance data

    * implement ability to import/require external scripts

    * replace `cachedRead` with regular read

    * extract codeblock language union to its own exported type
    to avoid repitition

    * add script cache

    * - set `DatacoreScript.code` to null upon succesful script loading
      (this is to free up memory)
    - switch to array for loaded scripts tracking
    - add `source` property to `DatacoreScript`

    * incorporate `ScriptCache` into local api

    * fix order

    * nits

    (cherry picked from commit 2bdfa8e)

    * change `ScriptCache.load`
    - this method now takes a parent `DatacoreLocalApi` instance as a parameter
    - create a new instance of `DatacoreLocalApi` for each recursively loaded script
    - throw on failure instead of returning null (so that it displays properly in a codeblock)

    * change `dc` to `parentContext` in failure case

    * formatting nits

    * corrections to script codeblock detection

    * implement suggested changes
    - move loaded script cache into ScriptCache
    - use `cachedRead`
    - use a map instead of an array
    - extract `convert` from class into separate utility function
    - lift `code` property of `DatacoreScript` up into the return value of `resolveSource`

    * more changes
    - add promise property to `DatacoreScript` interface
    - return a previous promise containing the evaluation result if it exists

    * add back anti-cycle guard, make scriptCache class field not readonly

commit 101cc20
Author: Michael Brenan <michael@brenan.dev>
Date:   Tue Jul 2 02:49:42 2024 -0500

    Add more javascript docs

commit b95b3dc
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 15:52:21 2024 -0700

    Auto-release beta 0.1.10

commit 81903d5
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 15:51:58 2024 -0700

    Fix new test formatting

commit d447b6e
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 15:51:30 2024 -0700

    Add line range test

commit 267c614
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 15:51:06 2024 -0700

    Fix up min versions for manifests

commit d75046c
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 01:03:04 2024 -0700

    Auto-release beta 0.1.9

commit fb4f857
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 01:02:17 2024 -0700

    Fix up line span embeds as a first pass

commit ffe2698
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 00:41:34 2024 -0700

    Fix formatting

commit b7b078d
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 00:41:19 2024 -0700

    Fix block level tagging and link tagging

commit 6e9eb74
Author: Michael Brenan <michael@brenan.dev>
Date:   Sun Jun 30 00:37:46 2024 -0700

    Fix broken local API components & start of embed CSS

commit 2623523
Author: Michael Brenan <michael@brenan.dev>
Date:   Sat Jun 29 23:07:47 2024 -0700

    Use backup source path for SpanEmbed
@GamerGirlandCo
add ability to create views for queries that are treated like any oth…
c8932a1 
…er file view (e.g., they can be dragged into the sidebar)
@GamerGirlandCo
remove duplicate $cleantext property in list item class
4be0bab
@GamerGirlandCo
remove old file
dce2f7d
@GamerGirlandCo
fix errors
96b45f1
@GamerGirlandCo
remove old docs artifacts
6cd3884
@GamerGirlandCo
re-add 1 to list.position.end.line in markdown import
8c0b524
@GamerGirlandCo
fix failing check
4ebdfa3
@GamerGirlandCo
run formatter
1468750
@GamerGirlandCo
remove merge conflict markers
974080f
@GamerGirlandCo GamerGirlandCo force-pushed the feat/editable-vanilla-columns branch from 79643ab to 974080f Compare October 28, 2024 00:05
@GamerGirlandCo
Copy link
Collaborator Author

closing this because i plan to delete my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacksmithgu blacksmithgu Awaiting requested review from blacksmithgu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GamerGirlandCo