Show command keybindings in popup #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension/popup.js
Outdated
| } | ||
| } | ||
|
|
||
| var commands = chrome.commands.getAll(function(commands) { |
There was a problem hiding this comment.
It is necessary to set this to 'var commands'? I don't see you using commands anywhere, but maybe this is some javascript foo I don't know.
There was a problem hiding this comment.
Ah. I had originally saved the commands away and foreached them (or whatever). Then I thought of using map, but forgot to remove the variable. Good catch.
blairconrad
force-pushed
the
show-keybindings
branch
from
86dc201
to
a8be255
Compare
paulsbduncan
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.