Allow arbitrary model size + safe refactoring #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. These smaller targeted changes are much easier to review. |
johnmarksilly
added a commit
to johnmarksilly/frigate
that referenced
this pull request
Jan 13, 2022
This reverts commit 9edf383.
johnmarksilly
added a commit
to johnmarksilly/frigate
that referenced
this pull request
Jan 13, 2022
This reverts commit 9edf383.
johnmarksilly
added a commit
to johnmarksilly/frigate
that referenced
this pull request
Feb 11, 2022
This reverts commit 6dfcc33.
johnmarksilly
added a commit
to johnmarksilly/frigate
that referenced
this pull request
Feb 11, 2022
This reverts commit 6dfcc33.
blakeblackshear
pushed a commit
that referenced
this pull request
Feb 19, 2022
Co-authored-by: YS <ys@gm.com>
NickM-27
pushed a commit
to NickM-27/frigate
that referenced
this pull request
Feb 20, 2022
Co-authored-by: YS <ys@gm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on TensorRT/Gstreamer I made a couple of changes, which seems safe to be merged upfront. Those changes should not change existing behavior in any way. The reason for them is to make multi-detector refactoring (edgetpu + TensorRT) easier. Changes are:
load_labelsinto thefrigate.utilscalculate_regionfunction receives the additional parametermodel_sizewhich adds flexibility to use models with different resolutions, such as 266 and 416tuple->Tupletype fix