Fix Go package self-test failure, introduced by a9145135 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously failing Go package self-test due to incorrect version spec syntax in a914513, which had "go-version: '1.20'" in test.yml. Correct status badge stuck on "Passing", hiding CI failures such as the above, by dropping use of GitHub status badges altogether, for reasons elaborated in README.md.tmpl. Drop Windows-based test: There is no Windows-specific code in Goat. Tidy the pre-push workflow for contributors.
blampe
approved these changes
Jun 17, 2024
|
Yes, thanks, I've now accepted the invitation (within the time limit). I do hope you'll be able to continue to be the primary integrator of PRs. For project stability I'm sure it's best to have a BDFL. Regarding merging of PRs, I noticed that for-blampe-5.0 was "squash-merged", whereas earlier PRs got a merge-commit. To me, merge-commit or rebase-and-merge seem better, primarily because they preserve regression debugging by means of bisecting the patch series. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously failing Go package self-test due to incorrect version spec syntax in a914513, which had "go-version: '1.20'" in test.yml.
Correct status badge stuck on "Passing", hiding CI failures such as the above, by dropping use of GitHub status badges altogether, for reasons elaborated in README.md.tmpl.
Drop Windows-based test: There is no Windows-specific code in Goat.
Tidy the pre-push workflow for contributors.