Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parametrized testing for spot exchanges #170

Merged
merged 6 commits into from
May 7, 2022

Conversation

matiaskotlik
Copy link
Collaborator

development

@CLAassistant
Copy link

CLAassistant commented May 4, 2022

CLA assistant check
All committers have signed the CLA.

@matiaskotlik matiaskotlik changed the base branch from main to development May 4, 2022 15:38
@matiaskotlik
Copy link
Collaborator Author

matiaskotlik commented May 4, 2022

@EmersonDove you can merge this if you'd like but keep the PR itself open -- there's infinite bugs that the tests have exposed and I want to fix them on this branch instead of making a bunch of branches for each one.

@EmersonDove
Copy link
Member

The homogeneity tests have a good number of ignores/exceptions depending on exchange that will have to be ported into this, that could be where the errors are coming from,

@matiaskotlik matiaskotlik merged commit dcdf3f2 into blankly-finance:development May 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants