Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mapObject utility performance can be improved #1

Closed
blazeshomida opened this issue Jun 2, 2024 · 0 comments · Fixed by #2
Closed

fix: mapObject utility performance can be improved #1

blazeshomida opened this issue Jun 2, 2024 · 0 comments · Fixed by #2

Comments

@blazeshomida
Copy link
Owner

Use for loop instead of reduce.
blazeshomida added a commit that referenced this issue Jun 3, 2024
@blazeshomida
fix: ⚡ improve mapObject utility performance and general refactor
0252838 
- 💡 Replaced `reduce` with a `for` loop in `mapObject` for better performance (closes #1)
- ♻️ Refactored `mapObject` and `mapThemeColors` for clarity
- 🎨 Improved function documentation and type definitions
- ✨ Introduced new helper functions `mapThemeColors` and `mapThemeBase` to simplify `shadcnTwPlugin` implementation

Enhanced performance and maintainability by optimizing the `mapObject` utility and refactoring related functions.
@blazeshomida blazeshomida mentioned this issue Jun 3, 2024
Merged
blazeshomida added a commit that referenced this issue Jun 3, 2024
@blazeshomida
fix: ⚡ improve mapObject utility performance and general refactor
d87670b 
- 💡 Replaced `reduce` with a `for` loop in `mapObject` for better performance (closes #1)
- ♻️ Refactored `mapObject` and `mapThemeColors` for clarity
- 🎨 Improved function documentation and type definitions
- ✨ Introduced new helper functions `mapThemeColors` and `mapThemeBase` to simplify `shadcnTwPlugin` implementation

Enhanced performance and maintainability by optimizing the `mapObject` utility and refactoring related functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf/general blazeshomida/shadcn-tw-plugin
1 participant
@blazeshomida