Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal on tweener (race condition) #812

Closed
dlamkins opened this issue Dec 14, 2022 · 2 comments · Fixed by #885
Closed

Fatal on tweener (race condition) #812

dlamkins opened this issue Dec 14, 2022 · 2 comments · Fixed by #885
Labels
bug Something isn't working or doesn't work as expected.

Comments

@dlamkins
Copy link
Member

lish_HUD.DebugService | Blish HUD encountered a fatal crash!
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
at Glide.Tween.TweenerImpl.AddAndRemove() in D:\a\Blish-HUD\Blish-HUD\Blish HUD\Library\Glide\Tweener.cs:line 225
at Glide.Tween.TweenerImpl.Tween[T](T target, Object values, Single duration, Single delay, Boolean overwrite) in D:\a\Blish-HUD\Blish-HUD\Bli

@dlamkins dlamkins added the bug Something isn't working or doesn't work as expected. label Dec 14, 2022
@dlamkins
Copy link
Member Author

dlamkins commented Apr 13, 2023

We should rewrite the tweener stuff to be fully thread-safe without breaking any of the public-facing APIs it exposes. With the majority of our UI framework now thread-safe, we should strive to ensure the dependencies are as well. Currently, we give a false sense of safety, which bites us now and again. This is especially common with views which can end up built on a different thread - not something modules can easily control.

@dlamkins
Copy link
Member Author

dlamkins commented Jul 4, 2023

Eksime makes good points here:
#885 (comment)

The Glide library we decided to use early on is old and beyond the "magic" it adds, it's likely more trouble than it is worth sticking with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or doesn't work as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant