Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TrackBar value generation/tracking #484 #556

Merged
merged 6 commits into from
Dec 21, 2021

Conversation

entrhopi
Copy link
Member

Fix for #484

@dlamkins dlamkins self-requested a review December 14, 2021 22:37
@dlamkins
Copy link
Member

Okay, this already feels a ton better than it did before.

Only issue I notice remaining is that without the drag offset being traced, the nub always snaps with the offset shown below:

image

The drag offset, if I remember correctly was to help remember how off we were offset on the nub to remember that as we dragged it. Regardless, the snapping appears to be very little so this is quite nice.

@dlamkins
Copy link
Member

I'll check it out tonight!

Copy link
Member

@dlamkins dlamkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttery smooth! This is great and I love the new 10% increments - they feel great. 👍

@dlamkins dlamkins merged commit 1aa5894 into blish-hud:dev Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants